Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: campaign application #1976

Conversation

gparlakov
Copy link
Contributor

  • fix order of fields (make the goal the last field on the 3-rd step)
  • remove "Membership" from the list of campaign types (it's a system type)

- fix order of fields (make the goal the last field on the 3-rd step)
- remove "Membership" from the list of campaign types (it's a system type)
@gparlakov gparlakov added the run tests Allows running the tests workflows for forked repos label Nov 16, 2024
Copy link

github-actions bot commented Nov 16, 2024

✅ Tests will run for this PR. Once they succeed it can be merged.

@github-actions github-actions bot removed the run tests Allows running the tests workflows for forked repos label Nov 16, 2024
Copy link
Member

@sashko9807 sashko9807 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it would be better to add some flag to the BE to manage campaignTypes visibility, so if a type is renamed for some reason, we won't need to make changes to FE. Though I suppose this would do for now

@gparlakov gparlakov merged commit 9dfbca6 into podkrepi-bg:master Nov 22, 2024
10 of 12 checks passed
@gparlakov gparlakov deleted the campaign-application-fix-order-and-hide-membership branch November 22, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants